Liu 349 #226
Liu 349 #226
Conversation
| # @param execution_time Execution Time/5/Float/ComponentParameter/readonly//False/False/Estimated execution time | ||
| # @param num_cpus No. of CPUs/1/Integer/ComponentParameter/readonly//False/False/Number of cores used | ||
| # @param group_start Group start/False/Boolean/ComponentParameter/readwrite//False/False/Is this node the start of a group? | ||
| # @param sleep_time sleep_time/5/Integer/ApplicationArgument/readwrite//False/False/The number of seconds to sleep |
There was a problem hiding this comment.
Minor thought: Now that we don't have both a name AND text, we can remove the second occurrence of the parameter name (i.e. sleep_time) here. Would require updating dlg_paletteGen, so maybe worth doing in a seperate branch.
| # @param num_cpus No. of CPUs/1/Integer/ComponentParameter/readonly//False/False/Number of cores used | ||
| # @param group_start Group start/False/Boolean/ComponentParameter/readwrite//False/False/Is this node the start of a group? | ||
| # @param sleep_time sleep_time/5/Integer/ApplicationArgument/readwrite//False/False/The number of seconds to sleep | ||
| # @param appclass appclass/dlg.apps.simple.RandomArrayApp/String/ComponentParameter/readonly//False/False/Application class |
There was a problem hiding this comment.
I've forgotten why you told me that you'd switched these all to use RandomArrayApp instead of their specific apps
| # @param num_of_copies num_of_copies/4/Integer/ConstructParameter/readwrite//False/False/Specifies the number of replications of the content of the scatter construct | ||
| # @param group_start group_start/False/Boolean/ComponentParameter/readwrite//False/False/Is this node the start of a group? | ||
| # @param n_tries n_tries/1/Integer/ComponentParameter/readwrite//False/False/Specifies the number of times the 'run' method will be executed before finally giving up | ||
| # @param appclass appclass/dlg.apps.simple.GenericScatterApp/String/ComponentParameter/readonly//False/False/Application class |
There was a problem hiding this comment.
This one, and a few more below, are still the old specific app (e.g. GenericScatterApp) instead of the RandomArrayApp
| self._link_drops(slgn, tlgn, sdrop, tdrop, lk) | ||
| else: | ||
| lpaw = ("%s-%s" % (sid, tid)) in self_loop_aware_set | ||
| if ( | ||
| slgn.group is not None | ||
| and slgn.group.is_loop | ||
| and lpaw | ||
| and slgn.h_level < tlgn.h_level | ||
| and slgn.h_level > tlgn.h_level |
There was a problem hiding this comment.
I don't understand this section of code, but it seems strange to swap the sign here and below without changing other logic. Just want to double check it is expected.
| self._converted = False | ||
| self._h_level = None | ||
| self._h_level = None # hierarcht level |
|
I have addressed the issues raised and also a few additional problems. Closing this now. |
We are working towards re-implementing parts of the translator engine. One big preparation step has been done in LIU-348 and that branch now forms the baseline for the rest of the work. In LIU-349 the following features have been implemented:
NOTE: These changes are also aligned already with changes in EAGLE that are currently sitting in the eagle-1022 branch.