Lg web graph downloads #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Javascript cleanup.
…' form submit button to reflect state of 'deploy' checkbox. Modified existing '/gen_pg' route on lg web to listen for 'deploy' form field and if false, return a JSON of the PG without deploying.
…pplications that can be used to automatically generate EAGLE components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to download:
I've added a new button beneath the translator PGT display ("Export to JSON")
A click on the "Export to JSON" button calls client-side javascript, makeJSON(), which uses the existing /pgt_jsonbody server route to generate and return JSON.
Also added a checkbox near the 'Generate & Deploy Physical Graph' button ("Deploy")
The "Deploy" checkbox is checked by default and the functionality remains the same. However, if the user un-checks the "Deploy" checkbox, the 'Generate & Deploy Physical Graph' button will change to read 'Generate Physical Graph', and when the user clicks on the button, the physical graph will be downloaded as JSON.
A small change to the /gen_pg route in lg web was required to support this functionality. It checks the form submission for a field named 'dlg_mgr_deploy'. If found, the deployment part of the route will be skipped and a JSON response is generated.