Update merklelib to support Python3.10 #243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The version of
merklelib
currently stored on Pypi is not up-to-date with the repository, which means we do not have changes that make it compatible with Python 3.10 (vpaliy/merklelib#10).Solution
We could point to the GitHub repository instead of trying for the Pypi project, but unfortunately there are outstanding issues with the setup.py that have not been remedied (vpaliy/merklelib#11).
@pritchardn has a repository that is up-to-date with the original/base repository, and we have merged a fix for the setup.py script (see pritchardn/merklelib#1).
We will use this version of the merkelib moving forward and pull it directly from GitHub when installing DALiuGE.
Testing
Confirmed the installation works as expected using
pip install
:Translator tests now pass as expected.