Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run-unit-tests.yml to reduce log-spam from stderr #250

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

myxie
Copy link
Collaborator

@myxie myxie commented May 7, 2024

Problem

It looks like we have an issue with multiple handlers being created when running the translator, which causes significant log spam for the same lines:

2024-05-06 08:35:48,666 [ INFO] [     MainThread] dlg.common.reproducibility.reproducibility#init_lgt_repro_data:723 Reproducibility data finished at LGT level
2024-05-06 08:35:48,666 [ INFO] [     MainThread] dlg.common.reproducibility.reproducibility#init_lgt_repro_data:723 Reproducibility data finished at LGT level
2024-05-06 08:35:48,666 [ INFO] [     MainThread] dlg.common.reproducibility.reproducibility#init_lgt_repro_data:723 Reproducibility data finished at LGT level
2024-05-06 08:35:48,666 [ INFO] [     MainThread] dlg.common.reproducibility.reproducibility#init_lgt_repro_data:723 Reproducibility data finished at LGT level
2024-05-06 08:35:48,666 [ INFO] [     MainThread] dlg.common.reproducibility.reproducibility#init_lgt_repro_data:723 Reproducibility data finished at LGT level
2024-05-06 08:35:48,666 [ INFO] [     MainThread] dlg.common.reproducibility.reproducibility#init_lgt_repro_data:723 Reproducibility data finished at LGT level
2024-05-06 08:35:48,666 [ INFO] [     MainThread] dlg.common.reproducibility.reproducibility#init_lgt_repro_data:723 Reproducibility data finished at LGT level
2024-05-06 08:35:48,666 [ INFO] [     MainThread] dlg.common.reproducibility.reproducibility#init_lgt_repro_data:723 Reproducibility data finished at LGT level
2024-05-06 08:35:48,666 [ INFO] [     MainThread] dlg.common.reproducibility.reproducibility#init_lgt_repro_data:723 Reproducibility data finished at LGT level
2024-05-06 08:35:48,666 [ INFO] [     MainThread] dlg.common.reproducibility.reproducibility#init_lgt_repro_data:723 Reproducibility data finished at LGT level
.....

2024-05-06 08:35:48,664 [ INFO] [     MainThread] dlg.dropmake.pg_generator#fill:61 Filling Logical Graph with parameters: {}
2024-05-06 08:35:48,664 [ INFO] [     MainThread] dlg.dropmake.pg_generator#fill:61 Filling Logical Graph with parameters: {}
2024-05-06 08:35:48,664 [ INFO] [     MainThread] dlg.dropmake.pg_generator#fill:61 Filling Logical Graph with parameters: {}
2024-05-06 08:35:48,664 [ INFO] [     MainThread] dlg.dropmake.pg_generator#fill:61 Filling Logical Graph with parameters: {}
2024-05-06 08:35:48,664 [ INFO] [     MainThread] dlg.dropmake.pg_generator#fill:61 Filling Logical Graph with parameters: {}
2024-05-06 08:35:48,664 [ INFO] [     MainThread] dlg.dropmake.pg_generator#fill:61 Filling Logical Graph with parameters: {}
2024-05-06 08:35:48,664 [ INFO] [     MainThread] dlg.dropmake.pg_generator#fill:61 Filling Logical Graph with parameters: {}
....

This makes it quite difficult to see the error failures that are reported in our CI workflows because the logs are polluted by this duplication.

Solution

At some point we should investigate why so many handlers are being created; for the time being, I have added --show-capture=no to the test command, so that pytest ignores stderr output.

@myxie myxie marked this pull request as ready for review May 8, 2024 01:37
@@ -53,6 +53,37 @@
"x": 220.2871317489371,
"y": 488.67884359131426
},
{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awicenec was this commit intended for this branch?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because we have deprecated the Description node. Description now is not a special node on the graph, but part of the graph metadata.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. If you're happy with these changes then I will merge.

@myxie myxie merged commit 6ff595e into master Jun 4, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants