Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIU-390: Remove Plasma and PyArrow #269

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Conversation

myxie
Copy link
Collaborator

@myxie myxie commented Jun 19, 2024

Issue

We want to deprecate/remove Plasma and PyArrow as they are preventing us from running DALiuGE in Python 3.11+; see LIU-390 for more details.

Solution

I have removed all reference to Plasma and PyArrow from the repository, and added that code to the external daliuge-plasma-components repository.

Summary by Sourcery

Removed support for Plasma and PyArrow, including related classes, imports, and tests.

  • Tests:
    • Removed tests related to PlasmaDROP and PlasmaFlightDROP from test_drop.py and test_droputils.py.

Copy link

sourcery-ai bot commented Jun 19, 2024

Reviewer's Guide by Sourcery

This pull request removes all references to Plasma and PyArrow from the daliuge-engine codebase. This includes the deletion of the PlasmaIO and PlasmaFlightIO classes, removal of related imports, and the deletion of test cases and utility functions that relied on PlasmaDROP and PlasmaFlightDROP. Additionally, the plasmaflight.py and plasma.py files have been deleted.

File-Level Changes

Files Changes
daliuge-engine/dlg/data/io.py
daliuge-engine/dlg/data/drops/__init__.py
daliuge-engine/dlg/graph_loader.py
daliuge-engine/dlg/apps/plasmaflight.py
daliuge-engine/dlg/data/drops/plasma.py
Removed all references to Plasma and PlasmaFlight from the data IO and drop management modules.
daliuge-engine/test/test_drop.py
daliuge-engine/test/test_droputils.py
Removed all test cases related to PlasmaDROP and PlasmaFlightDROP.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @myxie - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@coveralls
Copy link

Coverage Status

coverage: 79.478% (+0.009%) from 79.469%
when pulling cc2a7d8 on LIU390-RemovePlasmaAndPyArrow
into db91b75 on master.

@myxie
Copy link
Collaborator Author

myxie commented Jun 20, 2024

@awicenec if you're happy with this I will merge it :)

@myxie myxie requested a review from awicenec June 20, 2024 05:35
@myxie myxie merged commit a055a77 into master Jun 21, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants