Yan 678

[davepallot]

Hi Rod,
This branch is related to https://jira.skatelescope.org/browse/YAN-678. If you have time can you have a look and see it all checks out? You should be able to run the unit test independent of the others daliuge-engine/test/apps/test_plasma.py.

Cheers
Dave

[coveralls]

Coverage decreased (-0.7%) to 76.737% when pulling e0f7487 on YAN-678 into ea54ebb on master.

[rtobar]

Looks good, other than some minor things. If I understand correctly, this is still following what we discussed last week, namely using plasma in a more "vanilla" way to demonstrate we can exchange data through it, and not necessarily trying to mimic/wrap what we are doing on the ingest pipeline + plasma_stman front.

[davepallot]

Looks good, other than some minor things. If I understand correctly, this is still following what we discussed last week, namely using plasma in a more "vanilla" way to demonstrate we can exchange data through it, and not necessarily trying to mimic/wrap what we are doing on the ingest pipeline + plasma_stman front.

Thats correct, this is just a demonstration and the next sprint will likely be a 'replication' of the cbf in daliuge form (is my understanding).

[davepallot]

@rtobar made changes: d0ee3fd

[rtobar]

New small round of comments, sorry if I wasn't too clear the first time!

[rtobar]

Looks great now! Please go ahead with merging when convenient.