Python3 only #35
Merged
Python3 only #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
The only required change to perform this removal is simply to make the statement. To make this statement stronger we are also removing 2.7 from our build matrix. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Now that we don't support Python 2.7 anymore there's no point on keeping our dependency on six. This commit removes this dependency, and replaces all usage of six with the appropriate python 3 code. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
There previously were only two more methods six didn't provide and we did: b2s and u2s. These were defined separately for pyton 2.7 and 3, which isn't necessary anymore. Moreover the u2s method is completely unnecessary now, and since it was used only on a single module that module was updated as well. The b2s method could also still be removed in theory, but it would require touching quite a few more lines of code in many modules, so I'll refrain from doing it at the moment to keep changes small. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
This version of python will be supported until 2023, while 3.6 will end support at the end of this calendar year. Establishing 3.7 as our baseline also simplifies our dependency requirements, which is a nice bonus. To reflect this change on the minimum support python version I've removed the old versions from our matrix builds. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
|
@rtobar Changes look fine. All tests pass. Go ahead and merge. |
|
Thanks @davepallot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of commits incrementally move the minimum supported python version from 2.7 up to 3.7. First, python 2.7 support is removed, then all usage of
sixis removed and changed for the corresponding python 3 code. Additional code within daliuge to deal differently with python 2/3 was also adjusted/removed. Later on the minimum supported version is moved up again to python 3.7, which finally allows us to simplify our dependency management a bit.