LIU-65: Generate individual log files per session. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtobar
approved these changes
Jul 7, 2021
| return False | ||
|
|
||
| fmt = '%(asctime)-15s [%(levelname)5.5s] [%(threadName)15.15s] ' | ||
| fmt += '[%(session_id)10.10s] [%(drop_uid)10.10s] ' |
There was a problem hiding this comment.
Here I'd remove appending the session_id, as it's already in the name of the file.
Comment on lines
106
to
108
| if hasattr(record, 'session_id'): | ||
| return record.session_id == self.sessionId | ||
| return False |
There was a problem hiding this comment.
Maybe simpler to use return getattr(record, 'session_id', None) == self.sessionId
awicenec
pushed a commit
that referenced
this pull request
May 19, 2022
LIU-65: Generate individual log files per session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate individual log files per session and propagates default/user specified log file location.