Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liu 104 #43

Merged
merged 5 commits into from
Jul 14, 2021
Merged

Liu 104 #43

merged 5 commits into from
Jul 14, 2021

Conversation

awicenec
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-9.07%) to 68.172% when pulling da59c17 on liu-104 into 11b7aeb on master.

@coveralls
Copy link

coveralls commented Jul 14, 2021

Coverage Status

Coverage decreased (-0.4%) to 76.876% when pulling 0163bd6 on liu-104 into 11b7aeb on master.

@awicenec
Copy link
Contributor Author

This fixes a long standing issue with the translator using only either "1" or 1 for True and "0" or 0 for False for group_start and group_end parameters.
Since this is really annoying and we keep producing graphs with wrong values this new implementation now supports the following:

True == true == 1 == “True” == “true” == “1”

False == false == 0 == <any string not in [“True”, “true”, “1”]>

NOTE: EAGLE has a bug here as well and will convert “True” (or any other string other than "true") to false. Maybe it should implement the same logic instead, or a more restricted one, like the one described in EAGLE-413.

@awicenec awicenec merged commit 9d8ce20 into master Jul 14, 2021
@awicenec awicenec deleted the liu-104 branch July 14, 2021 05:33
awicenec added a commit that referenced this pull request May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants