merge #48
Merged
merge #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In FileDROP's setCompleted call we update the _size attribute by issuing an os.stat call. This call can fail when the file is not present, which in turn happens when none of its producers actually wrote anything into it. Depending on the context, the error will be visible or not (e.g., it might not appear in the logfiles if the call was issued on a thread with no high-level try/catch+log block -- like those spawned by AppDrop.execute). This commit fixes this by catching errors from the os.stat call. Additionally when the file has not been created we create it; this way we prevent consuming applications to fail reading from a non-existing file. A unit test has been included to reproduce this setup in a simple way. This problem was reported in LIU-111. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
FileDROP.setCompleted is almost a verbatim copy of Drop.setCompleted, but it was missing the new additions from the new SKIPPED state. At some point we should look into merging these two implementations to avoid code duplication. Together with this fix, I've modified the existing branch tests to ensure branches work with FileDROPs as well. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
awicenec
pushed a commit
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.