Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIU-165 Docker Service Drops #61

Closed
wants to merge 17 commits into from

Conversation

calgray
Copy link
Collaborator

@calgray calgray commented Aug 23, 2021

Here I've added a new type of drop known as a 'serviceapp' which essentially cannot be a leaf node in a physical graph. To demonstrate this I've added a DOCKER_SERVICE drop category that generates a DockerApp class with a serviceapp type.

Running a docker container this way will now not block execution of the graph and will automatically remove the docker container with the default removeContainer drop property.

image

The original Service drop can use the same serviceapp type potentially with an input application or as a group drop (will need clarification on what the desired behavior is)

EDIT: After demo some discovered nice to haves are:

  • Make regular service drops work the same way when using a docker input app
  • Triggering the stop node on the graph can also stop long running services
  • Services may want to use different colors on the DIM session graph view (pink for running? blue for complete?)

@coveralls
Copy link

coveralls commented Aug 23, 2021

Coverage Status

Coverage decreased (-0.2%) to 76.975% when pulling 1c500c9 on LIU-116-dockerservice-drops into 1dca409 on LIU-117-plasmaflight.

@calgray calgray changed the title LIU-116 Docker Service Drops LIU-165 Docker Service Drops Aug 24, 2021
@calgray
Copy link
Collaborator Author

calgray commented Aug 24, 2021

Combining with #60

@calgray calgray closed this Aug 24, 2021
@calgray calgray deleted the LIU-116-dockerservice-drops branch August 27, 2021 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants