Yan 812 2 #81
Merged
Yan 812 2 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, this is not ready to pull. Some of the unit tests are failing due to these changes. |
…e handled previously)
|
There is now one change to the daliuge code. EAGLE introduced a new node Category called "Unknown Application". This is used where an application is named (usually in an old graph) but EAGLE doesn't know whether the application is Python/Dynlib/Bash etc. The change to the code now makes daliuge handle the "UnknownApplication" node the same way it used to handle nodes with the category "None". |
awicenec
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated graphs to EAGLE 4.0.x format.
Removed two graphs in daliuge-translator/dlg/dropmake.
I can't see that these were used in the unit tests, and they were stored in AppRef format, which we no longer use, so I'm assuming they are not necessary.