LIU-165: Service Drops Fix #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested with the following graph that drops of several megabytes in size can serialize deserialize as expected (making sure to raise the default plasma store shared memory size). Reading around ~100Mb started causing a new issue that is logged in https://icrar.atlassian.net/browse/LIU-213
|
awicenec
approved these changes
Dec 9, 2021
pritchardn
pushed a commit
that referenced
this pull request
May 20, 2022
LIU-165: Service Drops Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that the translator is currently trying to create a service drop and the input app into the physical graph which is causing _create_test_drop_spec to raise an exception (I get the impression that this method wasn't intended for production)
I've updated the logic in lgn_to_pgn to explicitly filter out the parent node from the graph and change the child to service_app type in
make_single_drop.pg_generator.py is getting quite is large so I propose a refactor with pg.py, pgt.py and pgtp.py seperated out