LIU 189 Expose PyFuncApp #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calgray
commented
Dec 6, 2021
|
|
||
| def initialize(self, **kwargs): | ||
| object_id = self.uid | ||
| if len(self.uid) != 20: | ||
| object_id = np.random.bytes(20) | ||
| if self.object_id is None: | ||
| if not self.object_id: |
There was a problem hiding this comment.
I noticed an issue with plasma where an empty string id didn't trigger using the object id. Truthy logic will treat empty string and None as False.
awicenec
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I've exposed PyFuncApp, SCPApp, CRCStreamApp, SocketListenerApp daliuge apps such that they will be generated into the default daliuge apps palette (LIU-189, LIU-190, LIU-191, LIU-192 respectively)
Some components I had to modify to get a basic demo graph running for each:
PyFuncApp: Converted app to new component style and added a flag to replace pickling with ast/repr python literals. function_defaults parameter doesn't quite make sense in the component as it only works for kwargs determined at runtime but I've left it be to avoid rewriting unit tests. The fuction argument mapping I'd expected to map port name to function keyword but since in the example the ports and keywords have an order the dict values don't seem to matter. Example of a runnable graph below.