Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stefan #19

Merged
merged 6 commits into from
Oct 19, 2022
Merged

Stefan #19

merged 6 commits into from
Oct 19, 2022

Conversation

stefanwaterval
Copy link
Contributor

Worked on Lightcuve.fit(). Removed the if/elif statements for the models and replaced with dictionaries.
Also added the model training.

Copy link
Collaborator

@pscicluna pscicluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There's a few minor suggestions before merging.

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
pgmuvi/lightcurve.py Outdated Show resolved Hide resolved
stefanwaterval and others added 4 commits October 19, 2022 16:15
Co-authored-by: Peter Scicluna <pscicluna@users.noreply.github.com>
Co-authored-by: Peter Scicluna <pscicluna@users.noreply.github.com>
@pscicluna pscicluna merged commit ef9f574 into ICSM:main Oct 19, 2022
@pscicluna pscicluna mentioned this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants