Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Sentry #173

Merged
merged 9 commits into from Apr 7, 2019
Merged

Feat Sentry #173

merged 9 commits into from Apr 7, 2019

Conversation

spipau
Copy link
Contributor

@spipau spipau commented Apr 6, 2019

Adds bug-tracking and breadcrumb support to the project via Sentry. Please check if the project still builds on your side. Docs are here.

@spipau spipau added the enhancement New feature or request label Apr 6, 2019
@spipau spipau added this to the v1.1.0 milestone Apr 6, 2019
@spipau spipau self-assigned this Apr 6, 2019
@spipau spipau added this to To do in ICT4D.at Android News App via automation Apr 6, 2019
@spipau
Copy link
Contributor Author

spipau commented Apr 7, 2019

@rajasone I added the bug tracking to the settings screen, since a user should be able to disable sending data to us.

But I have a Dagger 2 problem with your last Dagger 2 improvements. I cannot inject anything in the Application class and I don't know why. Can you please check that out? I left some comments in the ICT4DNewsApplication.kt class

@spipau spipau merged commit 27b1527 into develop Apr 7, 2019
ICT4D.at Android News App automation moved this from To do to Done Apr 7, 2019
@spipau spipau deleted the feat-sentry branch April 7, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants