Refactor frontend to prepare for #5955.

ICTU · Dec 6, 2023 · f7e05c2 · f7e05c2
1 parent 69ffaf8
commit f7e05c2
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/components/frontend/src/metric/MetricDebtParameters.js b/components/frontend/src/metric/MetricDebtParameters.js
@@ -59,7 +59,7 @@ function TechnicalDebtEndDate({ metric, metric_uuid, reload }) {
         <DateInput
             ariaLabelledBy={labelId}
             requiredPermissions={[EDIT_REPORT_PERMISSION]}
-            label={<LabelWithDate date={metric.debt_end_date} labelId={labelId} help={help} label="Technical debt end date"/>}
+            label={<LabelWithDate date={metric.debt_end_date} labelId={labelId} help={help} label="Technical debt end date" />}
             placeholder="YYYY-MM-DD"
             set_value={(value) => set_metric_attribute(metric_uuid, "debt_end_date", value, reload)}
             value={metric.debt_end_date ?? ""}

diff --git a/components/frontend/src/sharedPropTypes.js b/components/frontend/src/sharedPropTypes.js
@@ -116,7 +116,9 @@ export const metricPropType = PropTypes.shape({
 })
 
 export const reportPropType = PropTypes.shape({
+    desired_response_times: PropTypes.object,
     issue_tracker: PropTypes.object,
+    report_uuid: PropTypes.string
 })
 
 export const reportsPropType = PropTypes.arrayOf(reportPropType)

diff --git a/components/frontend/src/source/SourceEntity.test.js b/components/frontend/src/source/SourceEntity.test.js
@@ -10,13 +10,13 @@ function renderSourceEntity(
         <Table>
             <Table.Body>
                 <SourceEntity
-                    status={status}
-                    status_end_date={status_end_date}
-                    hide_ignored_entities={hide_ignored_entities}
-                    entity_attributes={[{ key: "attr1" }, { key: "attr2", color: { bad: "warning" } }]}
                     entity={{ attr1: "good", attr2: "bad", first_seen: first_seen }}
+                    entity_attributes={[{ key: "attr1" }, { key: "attr2", color: { bad: "warning" } }]}
                     entity_name="entity"
+                    hide_ignored_entities={hide_ignored_entities}
                     rationale={rationale}
+                    status={status}
+                    status_end_date={status_end_date}
                 />
             </Table.Body>
         </Table>

diff --git a/components/frontend/src/subject/SubjectTable.js b/components/frontend/src/subject/SubjectTable.js
@@ -3,8 +3,8 @@ import PropTypes from 'prop-types';
 import { Table } from '../semantic_ui_react_wrappers';
 import { DataModel } from "../context/DataModel";
 import { DarkMode } from "../context/DarkMode";
-import { MetricDetails } from '../metric/MetricDetails';
 import { IssueStatus } from '../issue/IssueStatus';
+import { MetricDetails } from '../metric/MetricDetails';
 import { MeasurementSources } from '../measurement/MeasurementSources';
 import { MeasurementTarget } from '../measurement/MeasurementTarget';
 import { MeasurementValue } from '../measurement/MeasurementValue';
@@ -98,12 +98,12 @@ export function SubjectTable({
                                     first_metric={index === 0}
                                     last_metric={index === last_index}
                                     metric_uuid={metric_uuid}
+                                    reload={reload}
                                     report_date={reportDate}
                                     reports={reports}
                                     report={report}
-                                    subject_uuid={subject_uuid}
-                                    reload={reload}
                                     stopSorting={() => handleSort(null)}
+                                    subject_uuid={subject_uuid}
                                     visibleDetailsTabs={settings.visibleDetailsTabs}
                                 />
                             }