Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for using a perm link to a specific metric #2925

Closed
Sebastiaan127001 opened this issue Nov 26, 2021 · 1 comment · Fixed by #3169 or #3200
Closed

Allow for using a perm link to a specific metric #2925

Sebastiaan127001 opened this issue Nov 26, 2021 · 1 comment · Fixed by #3169 or #3200
Assignees
Labels
Feature New, enhanced, or removed feature
Projects

Comments

@Sebastiaan127001
Copy link
Contributor

It would be great to be able to use a URL to point to a specified metric to go there directly

@fniessink fniessink added the Feature New, enhanced, or removed feature label Nov 26, 2021
@fniessink fniessink added this to Prioritized in Backlog via automation Nov 26, 2021
@fniessink fniessink moved this from Backlog to Prioritized in Backlog Dec 11, 2021
@fniessink fniessink moved this from Prioritized to Refinement in progress in Backlog Dec 11, 2021
@fniessink
Copy link
Member

fniessink commented Dec 11, 2021

Some thoughts on this feature request.

In the metrics details view, metrics already have an id, so using the metric id as URL hash already works, more or less. Clicking http://www.quality-time.example.org/example-report-quality-time?tabs=038273af-8d71-4247-8235-fa9da3906a53%3A0#0cf96e46-3688-490d-97e2-2152687c4306 jumps to the metric with id 0cf96e46-3688-490d-97e2-2152687c4306. Unfortunately, after clicking the metric is under the menubar and thus not visible. This is solved in PR #3018 by adding

html {
    scroll-padding-top: 70px; /* height of sticky header */
}

to App.css. Tested with latest Safari, Chrome, and Firefox. Courtesy https://css-tricks.com/fixed-headers-on-page-links-and-overlapping-content-oh-my/

Besides fixing the menubar hiding the metric, the other thing needed is a button to copy the permanent link. Open question: where to have the button. I see a few options:

  1. A share button next the metric name in the subject tables
  2. A share button in the metric configuration tab
  3. A new metric tab for sharing, i.e. next to the configuration and change log tabs

The first two options would need some kind of popup that appears after clicking the button to indicate to the user that the URL was copied to the clipboard. The third option could show the URL in the tab together with a "copy link to clipboard" button. Advantage of the third option is that we could also use that method for subjects and reports.

Decision: First implementation will use option 3!

By the way, the link will have one limitation: since it contains both the report id and the metric id the perm link stops working if the metric is moved to another report.

@fniessink fniessink moved this from Refinement in progress to Prioritized in Backlog Dec 12, 2021
@fniessink fniessink moved this from Prioritized to Refinement in progress in Backlog Dec 15, 2021
@fniessink fniessink moved this from Refinement in progress to Ready in Backlog Dec 15, 2021
@fniessink fniessink moved this from Ready to Development in progress (max 4) in Backlog Jan 4, 2022
@fniessink fniessink self-assigned this Jan 4, 2022
fniessink added a commit that referenced this issue Jan 5, 2022
@fniessink fniessink moved this from Development in progress (max 4) to Merged in Backlog Jan 5, 2022
@fniessink fniessink moved this from Merged to Release candidate released in Backlog Jan 7, 2022
@fniessink fniessink moved this from Release candidate released to Released in Backlog Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New, enhanced, or removed feature
Projects
Backlog
Released
2 participants