Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the option to use a custom base image for the www container #9140

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Remove the option to use a custom base image for the www container #9140

merged 1 commit into from
Jul 4, 2024

Conversation

wkoot
Copy link
Contributor

@wkoot wkoot commented Jul 3, 2024

No description provided.

fniessink
fniessink reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@fniessink fniessink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe add a comment to the Dockerfile explaining why we're setting the capability?

@wkoot wkoot force-pushed the 8857-update-nginx-container branch 2 times, most recently from a293347 to 2e671e2 Compare July 4, 2024 11:37
@wkoot wkoot marked this pull request as ready for review July 4, 2024 11:41
@wkoot wkoot force-pushed the 8857-update-nginx-container branch from 2e671e2 to ddb2908 Compare July 4, 2024 12:09
@wkoot wkoot force-pushed the 8857-update-nginx-container branch from ddb2908 to f5107ea Compare July 4, 2024 12:14
@wkoot wkoot enabled auto-merge (squash) July 4, 2024 12:15
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@wkoot wkoot merged commit 64369e3 into master Jul 4, 2024
41 checks passed
@wkoot wkoot deleted the 8857-update-nginx-container branch July 4, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fniessink fniessink fniessink left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkoot @fniessink