Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Travis CI build #19

Conversation

peter279k
Copy link
Contributor

Changed log

  • Add the php-7.1, php-7.2 and php-7.3 version tests because they're stable versions.
  • The HHVM is split from PHP-7.x. Remove this and using the nightly version.
  • The php-7.1 is stable version currently, creating the code coverage report when using this version to do CI work.

@peter279k
Copy link
Contributor Author

peter279k commented Aug 11, 2019

The Travis CI build is failed because of the incorrect pre-build phpunit versions in Travis CI build.

To resolve issue, I think we should define the phpunit/phpunit package inside require-dev block in composer.json.

@olvlvl
Copy link
Member

olvlvl commented Aug 21, 2019

Hi Peter, I made some changes to master (#20), please rebase your branch.

@coveralls
Copy link

coveralls commented Aug 22, 2019

Coverage Status

Coverage remained the same at 95.47% when pulling 47ab759 on open-source-contributions:enhance_travis_ci into 9f985fa on ICanBoogie:master.

@peter279k
Copy link
Contributor Author

Hi @olvlvl, I've resolved the conflicts.

And the PR is going to be merged.

@peter279k
Copy link
Contributor Author

@olvlvl, sorry, the conflicted PR is broken, I close this PR and create another PR for this.

@peter279k peter279k closed this Aug 22, 2019
@peter279k peter279k deleted the enhance_travis_ci branch August 22, 2019 02:54
peter279k added a commit to open-source-contributions/DateTime that referenced this pull request Aug 22, 2019
@peter279k peter279k mentioned this pull request Aug 22, 2019
peter279k pushed a commit to open-source-contributions/DateTime that referenced this pull request Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants