Added the tests, estimates and made the general changes to One var Fit Model dialog #5861
Conversation
This reverts commit 88fa802.
Updating Branch
|
@Wycklife I am now taking up this to tidy the code and merge it into your branch. Thanks. |
Wycliffeonevarmodel
|
@Wycklife I saw you added the separator - if so, that's great. |
|
@Ivanluv @shadrackkibet and @rdstern Please could you review this? |
|
The MKinfer and Trend packages seem not to available at first when testing and so they have to be installed first.Will this be a problem? |
|
|
||
| ucrChkConvertVariate.SetText("Convert to Numeric") | ||
| ucrChkConvertVariate.AddParameterValueFunctionNamesCondition(True, "data", "as.numeric", True) | ||
| ucrChkConvertVariate.AddParameterValueFunctionNamesCondition(False, "data", "as.numeric", False) | ||
| ucrChkConvertVariate.AddParameterValueFunctionNamesCondition(False, "data", frmMain.clsRLink.strInstatDataObject & "$get_columns_from_data", True) |
There was a problem hiding this comment.
I don't think this is being used
| ucrDistribution = New ucrDistributions | ||
| ucrChkOmitMissing.Checked = True |
| Else | ||
| ucrDistributionChoice.SetExactDistributions() | ||
| End If |
There was a problem hiding this comment.
the else statement might not be needed.@shadrack could help us with this
Updating Master
| Private Sub AddAsNumeric() | ||
| If rdoTest.Checked Then | ||
| If ucrChkConvertVariate.Checked Then | ||
| If ucrInputComboTests.GetText() = "sign" Then |
There was a problem hiding this comment.
@Wycklife I think code line 691 to 735 can be immensely be optimised and shortened by using Select Case conditional syntax
| If rdoEstimate.Checked Then | ||
| If ucrChkConvertVariate.Checked Then | ||
| If ucrInputComboEstimate.GetText() = "mean" Then | ||
| clsMeanCIFunction.AddParameter("x", clsRFunctionParameter:=clsRConvertNumeric, iPosition:=0) |
There was a problem hiding this comment.
@Wycklife same here. The code block 798 to 815 can be optimised and shortened using the Select Case
There was a problem hiding this comment.
and also code block 817 to 835
| Private Sub ucrChkBinModify_ControlValueChanged(ucrChangedControl As ucrCore) Handles ucrChkBinModify.ControlValueChanged | ||
| SetBinomialTest() | ||
| BinomialConditions() | ||
| Private Sub tooltip() |
There was a problem hiding this comment.
@Wycklife probably use capital T, to be consistent with the other methods, Tooltip() instead of tooltip()
|
|
||
| End Sub | ||
|
|
||
| Private Sub ToolTip1_Popup(sender As Object, e As PopupEventArgs) Handles tttests.Popup |
There was a problem hiding this comment.
Empty sub Probably no longer needed?
| Private clsRplotFunction, clsRplotPPComp, clsRplotCdfcomp, clsRplotQqComp, clsRplotDenscomp As New RFunction | ||
| Private clsBionomialFunction, clsProportionFunction, clsSignTestFunction, clsTtestFunction, clsWilcoxonFunction, clsZTestFunction, clsBartelFunction, clsBrFunction, clsRunsFunction, clsSenFunction, clsSerialCorrFunction, clsSnhFunction, clsAdFunction, clsCvmFunction, clsLillieFunction, clsPearsonFunction, clsSfFunction As New RFunction | ||
|
|
||
| Private Sub ToolTip2_Popup(sender As Object, e As PopupEventArgs) |
There was a problem hiding this comment.
Empty sub, Probably no longer needed?
|
@Patowhiz am taking over this |
Updating Master
Updating branch
Display daily improvement
Fixes #5810
@africanmathsinitiative/developers This is still in progress.
@shadrackkibet Is working on the general code structure for this dialog before I proceed with my work.