Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined the last dialog and last 10 dialogs tool bars into one #7445

Merged
merged 8 commits into from May 30, 2022

Conversation

derekagorhom
Copy link
Contributor

@derekagorhom derekagorhom commented May 4, 2022

Fixes #7431
Combining the last dialog button to the last ten dialog button.
@Patowhiz and i removed the start and end ``separator for the code and would like to ask @rdstern if the start and end ``separator should be shown in the list just to make sure its Documented.

@derekagorhom
Copy link
Contributor Author

@Patowhiz here is the PR

@derekagorhom derekagorhom changed the title Frmmain changes for Toolstrip Bar Combines the last dialog and last 10 dialogs tool bars into 1 May 4, 2022
@Patowhiz
Copy link
Contributor

Patowhiz commented May 4, 2022

@rdstern I have circled the 2 separator lines that @derekagorhom and I are asking about in the screenshot below.

165923810-aa34a73a-e613-4d5d-8355-1bd80c80e067

@Patowhiz
Copy link
Contributor

Patowhiz commented May 5, 2022

@rdstern will be very useful if you could review this PR for our next week's workshop. Thanks.

@Patowhiz
Copy link
Contributor

Patowhiz commented May 6, 2022

@lloyddewit @rdstern @N-thony if this PR can be reviewed and merged, it would be very useful for our next workshop. We usually find it confusing to the users to have to use the 2 buttons instead of just 1.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works fine now and is a good simplification.
But it currently now has the tooltip "View Last Graph" It could say View/Edit Last Dialogue.
While correcting that I notice the 2 preceding buttons also say View Last Graph! (That's also in the released version!) Change them (back?) to Copy and Paste.

@derekagorhom
Copy link
Contributor Author

Hello @rdstern please i have made the changes, can you test them again

@Patowhiz
Copy link
Contributor

@derekagorhom you may have to resolve the conflicts then @rdstern you may have to retest and approve before more conflicts. This PR has changes in frmMain designer and code files.

Thanks.

@derekagorhom
Copy link
Contributor Author

@derekagorhom you may have to resolve the conflicts then @rdstern you may have to retest and approve before more conflicts. This PR has changes in frmMain designer and code files.

Thanks.

Done

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@shadrackkibet shadrackkibet changed the title Combines the last dialog and last 10 dialogs tool bars into 1 Combined the last dialog and last 10 dialogs tool bars into one May 30, 2022
@shadrackkibet shadrackkibet merged commit dc1f639 into IDEMSInternational:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combining the Open last dialogue button from the Toolstrip bar
4 participants