-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combined the last dialog and last 10 dialogs tool bars into one #7445
Combined the last dialog and last 10 dialogs tool bars into one #7445
Conversation
@Patowhiz here is the PR |
@rdstern I have circled the 2 separator lines that @derekagorhom and I are asking about in the screenshot below. |
@rdstern will be very useful if you could review this PR for our next week's workshop. Thanks. |
@lloyddewit @rdstern @N-thony if this PR can be reviewed and merged, it would be very useful for our next workshop. We usually find it confusing to the users to have to use the 2 buttons instead of just 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works fine now and is a good simplification.
But it currently now has the tooltip "View Last Graph" It could say View/Edit Last Dialogue
.
While correcting that I notice the 2 preceding buttons also say View Last Graph! (That's also in the released version!) Change them (back?) to Copy and Paste.
Hello @rdstern please i have made the changes, can you test them again |
@derekagorhom you may have to resolve the conflicts then @rdstern you may have to retest and approve before more conflicts. This PR has changes in Thanks. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Fixes #7431
Combining the last dialog button to the last ten dialog button.
@Patowhiz and i removed the
start and end ``separator
for the code and would like to ask @rdstern if thestart and end ``separator
should be shown in the list just to make sure its Documented.