Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Prepare>Data Reshape>Transpose Columns, ensured that New Names field is initially empty empty when Dialog is opened #7467

Conversation

EstherNjeriLiberatta
Copy link
Contributor

@EstherNjeriLiberatta EstherNjeriLiberatta commented May 10, 2022

Fixes #7461
Removed NULL from the New Names receiver and cleaned up the code.
This is not ready for review.

@lloyddewit
Copy link
Contributor

@EstherNjeriLiberatta Thanks for this.
Tip: if its not ready for review, it's best to click on Convert to draft.
image

@EstherNjeriLiberatta
Copy link
Contributor Author

Thank you @lloyddewit

@EstherNjeriLiberatta EstherNjeriLiberatta marked this pull request as draft May 10, 2022 09:12
@EstherNjeriLiberatta
Copy link
Contributor Author

EstherNjeriLiberatta commented May 12, 2022

I found these two bugs when fixing the dialogue:
The first image shows the selector not updating itself when I get back to the receiver Columns to Transpose. It should show all the columns of the dataset and not the columns previously selected.

image

The second image shows when the dialogue is reset. It is only showing the variables previously selected when both receivers are filled and not the columns of the whole dataset.
image

I have fixed these two bugs with help from @Ivanluv.
@rdstern @africanmathsinitiative/developers This is ready for review.

@EstherNjeriLiberatta EstherNjeriLiberatta marked this pull request as ready for review May 12, 2022 07:29
@lloyddewit lloyddewit changed the title Fixing bug in Transpose Dialogue. In Prepare>Data Reshape>Transpose Columns, ensured that New Names field is initially empty empty when Dialog is opened May 16, 2022
@lloyddewit lloyddewit added the bug label May 16, 2022
@lloyddewit lloyddewit merged commit 6891813 into IDEMSInternational:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Names Receiver not empty when Dialogue is opened, Prepare>Data Reshape>Transpose Columns.
3 participants