-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added three Replace options in the Find/Replace dialog #7484
Added three Replace options in the Find/Replace dialog #7484
Conversation
updating master
Updating Master.
updating master
Updating master
Updating master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you have yet to implement the replace cell. The radio buttons look fine.
Perhaps check the code to update the default name of the replace cell option. If I go to the replace options it seems ok. Then if I go to the cell option, then back to detect (radio button at the top) and then back to replace, then it still has the name detect.
@rdstern, I found a function to replace the cell, you can test it now. I also fixed the bug you referred to in your earlier comment. |
@anastasia-mbithe this seems a good start, but you are not yet checking carefully enough yourself first. Here is what I get, almost immediately: Now I don't get the error if I add quotes round the Y, but that is not done for the other options here. And I don't think - even then - that you are checking for the Ignore Case. So you have a bit to go. I wonder what data you are using? I am using the example from rrefine to start with. |
@rdstern, I have changed the function for the cell button. This finds the pattern and replaces everything in the cell with the value specified. However, since the function finding the pattern "grepl()" is a regular expression function, I have disabled the Modifiers group box when the checkbox is checked. The function also supports ignoring case. Kindly have a look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I hope the code is also ok so it can be merged soon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anastasia-mbithe Looks great, thank you.
I just renamed one of the variables.
Fixes (partially) #7304
This is still in progress. I am researching the function for the third option, replacing entire cell contents like it's done in Excel.