Fixed bug in the Start of Rains Dialog #7492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdstern
previously approved these changes
May 23, 2022
There was a problem hiding this comment.
@N-thony this looks to be fixed. So I am approving. I hope that @ChrisMarsh82 can check and merge.
I did notice that the dialogue ignores a filter, if one is applied. I checked back and this is also the case in Version 0.7.4, so perhaps to be examined later.
|
@N-thony I tested Climatic > Prepare > Spells dialogue and works fine. |
|
@N-thony I tested and it is now working. Thank you |
|
@shadrackkibet could you review this? Its R code which would be better for you to approve |
@N-thony on second thought the above changes make more sense. The previous method wasn't working when this bit is called in the `summary_tables` function.
shadrackkibet
approved these changes
May 31, 2022
rdstern
approved these changes
Jun 2, 2022
lloyddewit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7488
@lilyclements thanks for your support, @rdstern I had a quick look of it then requested help from Lily, this seems to be fixed now, please take a look.
@derekagorhom @VimbayiChimonyo could you also test?
@dannyparsons could you review this? Thanks.