Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed grid row sizes for shape file data frames #7516

Merged
merged 4 commits into from Jun 3, 2022
Merged

Fixed grid row sizes for shape file data frames #7516

merged 4 commits into from Jun 3, 2022

Conversation

Patowhiz
Copy link
Contributor

Fixes #7165
@africanmathsinitiative/developers this is ready for review.

@lloyddewit
Copy link
Contributor

@rdstern if you can test/approve, then we can merge, thanks

rdstern
rdstern approved these changes Jun 2, 2022
View reviewed changes
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. And helps our simple mapping that is in our climatic courses regularly now.

@lloyddewit lloyddewit changed the title Fixes grid row sizes for shape file data frames Fixed grid row sizes for shape file data frames Jun 3, 2022
@lloyddewit lloyddewit added the bug label Jun 3, 2022
@lloyddewit lloyddewit merged commit eb8089c into IDEMSInternational:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdstern rdstern rdstern approved these changes

@lloyddewit lloyddewit lloyddewit approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New grid has row size problem for some datasets
3 participants
@Patowhiz @lloyddewit @rdstern