Ensured that Column Metadata window opens with the default selected dataset in the Data View #7526
Conversation
…has changed from data view
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
|
@rdstern if you can test/approve, then we can merge, thanks |
There was a problem hiding this comment.
@N-thony great. I am also very happy that these are changes proposed by other than me. Also they are relatively small, but add to the convenience, and that is important for R-Instat. Our catch-phrase is "making it easy" and this sort of thing helps!
lloyddewit
changed the title
|
@N-thony @rdstern I have made a comment in issue #7477, kindly respond to it. I understand that this PR fixes the original issue, however after going through @rdstern comment, I think we may have introduced a functionality that is slightly from what is expected (subject to my opinion being corrected). Sorry for the late review. Thanks. |
1 similar comment
|
@N-thony @rdstern I have made a comment in issue #7477, kindly respond to it. I understand that this PR fixes the original issue, however after going through @rdstern comment, I think we may have introduced a functionality that is slightly from what is expected (subject to my opinion being corrected). Sorry for the late review. Thanks. |
|
@lloyddewit I have tried to test this with Linux version unfornately I was getting the following bug, I have fixed it in PR #7537 |
Fixes #7477
@rdstern I have made the improvement to the column meta data to change to the current data frame when the current data frame has changed from data view. Please have a look. Thanks
@africanmathsinitiative/developers this is ready for review.
@derekagorhom please have a look.