Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured that Y-axis settings are persistent when closing/re-opening PICSA Rainfall dialog #7612

Merged
merged 6 commits into from Jul 15, 2022

Conversation

Vitalis95
Copy link
Contributor

Fixes #7607
@rdstern @N-thony @lloyddewit this PR fixes the issue when you set Y-axis at any point then it doesn't unset itself when dialogue is used repeatedly

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vitalis95 this is much better and the control now seems to behave itself when the y-axis is numeric. But it still goes wrong when using dates. I will send you the data for the plot below through skype.

It would be excellent if you can fix this too, at the same time?

To be clear what I did. I first did plots where y is the sum_rain. I get the mean line and also set the y-axis to start at zero. All seems ok now.

Now I change and plot the start_rain. Now the y-axis is a date, and the default is for the y-axis to start at day 1. I untick this.
The graph works fine.
Then I return to the dialogue and the PICSA plot sub-dialogue. Then I go to the Lines tab. I don't change anything, but do the plot again. Now the graphs start on Jan 1. When I return the the PICSA sub-dialogue I find the y-axis control is ticked and at the default of 1. I hope you can prevent that?

@Vitalis95
Copy link
Contributor Author

@rdstern , can you have a look at it now

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vitalis95 excellent. Looks fine now. Many thanks. Hope @lloyddewit likes it so it can be merged.

@lloyddewit lloyddewit added the bug label Jul 15, 2022
@lloyddewit lloyddewit changed the title Fixed a Minor bug of Y-axis unsetting itself in PICSA Rainfall dialog Ensured that Y-axis settings are persistent when closing/re-opening PICSA Rainfall dialog Jul 15, 2022
@lloyddewit lloyddewit merged commit 09b57e8 into IDEMSInternational:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix remaining minor bug on PICSA graph dialogues
3 participants