Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filter for empty rows in Define New Filter dialog #7629

Merged
merged 11 commits into from Jul 18, 2022

Conversation

shadrackkibet
Copy link
Collaborator

@shadrackkibet shadrackkibet commented Jul 16, 2022

fixes #7617

@rdstern I added an option "isEmpty" into the dropdown. When you select this option it allows you to click Add Condition then you can select only empty rows. What do you think?
image

@rdstern
Copy link
Collaborator

rdstern commented Jul 17, 2022

That's an interesting way to do it - and seems to work fine. I thought we would just enable the As Condition button with an empty string, but I am also happy with this solution.
a) I assume we can name it as we want, so would is.empty, rather than isEmpty be more consistent with the is.na?
b) We should then also add !is.empty for the opposite - as we have for !is.na.

@shadrackkibet
Copy link
Collaborator Author

@rdstern I agree to the request above and I have actioned it accordingly.

rdstern
rdstern previously approved these changes Jul 17, 2022
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shadrackkibet this is great. Not the way I was thinking, but this way seems better. And excellent that you are back to R-Instat, even though no longer with INNODEMS. I hope @lloyddewit can approve, so you can proceed to the useful ADD facility after this is merged!

Copy link
Contributor

@lloyddewit lloyddewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shadrackkibet Tidy fix, thanks, happy to approve.
I just fixed a small indentation issue.

@lloyddewit lloyddewit changed the title Filtering of empty rows Added filter for empty rows in Define New Filter dialog Jul 18, 2022
@lloyddewit lloyddewit merged commit 8d0f441 into IDEMSInternational:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very small change in New-Filter sub-dialogue
3 participants