-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boxplot Options #7655
Boxplot Options #7655
Conversation
@N-thony , the recent commit fixes minor overlapping issues |
@rdstern please could you test? thanks |
@Fidel365 I note this (and some other of your pull requests seem to overlap with those by @EstherNjeriLiberatta . For this one - boxplots - how do your changes relate to her pull request in #7570 ? There are others that seem to overlap too. For example you have #7656 and @EstherNjeriLiberatta had #7572? |
@rdstern , we are working on the same dialogues but from different menus, we are trying to update all dialogues to geom options.e.g The boxplot commit follows the path Climatic>Describe>Boxplot |
@Fidel365 thank you for the clarification. It was just that at the top of your pull request, you mention the |
@EstherNjeriLiberatta can you test/review this? Thanks. |
@derekagorhom can you take it over? |
@Fidel365 still working on it, i will help him with the corrections |
@EstherNjeriLiberatta , this PR is ready for a rereview |
@EstherNjeriLiberatta Thank you for your review and comments above. I checked the new commit and all your comments above are resolved. @Fidel365 Thank you for your work on this PR. Is this PR ready for testing or are you still working on this? Thanks |
@lloyddewit , it's ready for testing |
@rdstern Please can you test? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@N-thony I thought we should re-allocate this work. I have many comments below.
But I have been working backwards in the pull requests and this seems to be duplicating #7570?
If so, then this can be closed, because the other is much better. If you agree, then simply close this one.
- Please note that the dialogue has now got out-of line - compare the position of the receivers for the Points and the Group option in 0.7.7 and the new one. I give both below:
And in the new one:
The Add Points and Groups to Connect should move back to their original positions.
b) Change Box to Boxplot
c) Add the other options (Tufte, Jitter, Violin) into the pull-down. Note that the work has been, because when I move to Jitter or Tufte or Violin and press on Box it goes to the right place.
d) I don't mind if they all remain available all the time. But if you are disabling those that don't apply, then note that you should enable Jitter, (as well as Boxplot) when you Add Points.
e) Also add Summary when you join the means/medians and go to stat_summary.?
Fixes(partially) #7556
Procurement>Describe>Numeric>Boxplot
@N-thony , this PR is ready for review