Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled Tmin and Tmax autofill automatically in Transform dialog #7669

Merged
merged 3 commits into from Jul 31, 2022
Merged

Enabled Tmin and Tmax autofill automatically in Transform dialog #7669

merged 3 commits into from Jul 31, 2022

Conversation

Vitalis95
Copy link
Contributor

Fixes #7664
@rdstern @lloyddewit @N-thony , this PR makes Tmin & Tmax update automatically for defined climatic data

@N-thony
Copy link
Collaborator

N-thony commented Jul 28, 2022

@Vitalis95 I tried with the rwanda dataset from the library but it didn't fill automatically
image

@N-thony
Copy link
Collaborator

N-thony commented Jul 28, 2022

@Vitalis95 I tried with the rwanda dataset from the library but it didn't fill automatically image

You can follow QC Temperature Dialogue as an example

@Vitalis95
Copy link
Contributor Author

@Vitalis95 I tried with the rwanda dataset from the library but it didn't fill automatically image

I used Dodoma dataset to test it and it worked fine, I will check on it
image

@Vitalis95
Copy link
Contributor Author

@N-thony , even for Rwanda dataset from Library, it works well from my side

image

N-thony
N-thony approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@N-thony N-thony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdstern could you test?

@lloyddewit lloyddewit added the bug label Jul 31, 2022
@lloyddewit lloyddewit merged commit 79be541 into IDEMSInternational:master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdstern rdstern rdstern approved these changes

@lloyddewit lloyddewit lloyddewit approved these changes

@N-thony N-thony N-thony approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor bug in the Transform Dialogue
4 participants
@Vitalis95 @N-thony @rdstern @lloyddewit