Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected misleading message in Tools > Install R package dialogue #7718

Merged
merged 4 commits into from Nov 24, 2022

Conversation

Ivanluv
Copy link
Contributor

@Ivanluv Ivanluv commented Aug 3, 2022

fixes #7707
@africanmathsinitiative/developers this is ready for review

instat/dlgRPackages.vb Outdated Show resolved Hide resolved
Copy link
Contributor

@lloyddewit lloyddewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ivanluv Thanks for adding the extra messages, I think this is a big improvement.
I added some extra comments

instat/dlgRPackages.vb Outdated Show resolved Hide resolved
instat/dlgRPackages.vb Outdated Show resolved Hide resolved
instat/dlgRPackages.vb Outdated Show resolved Hide resolved
instat/dlgRPackages.vb Outdated Show resolved Hide resolved
@lloyddewit
Copy link
Contributor

@Ivanluv I don't see the changes, did you push?

@Ivanluv
Copy link
Contributor Author

Ivanluv commented Aug 8, 2022

@Ivanluv I don't see the changes, did you push?

@lloyddewit could you check again

@lloyddewit
Copy link
Contributor

@rdstern please could you test? thanks

@rdstern
Copy link
Collaborator

rdstern commented Sep 10, 2022

@lloyddewit It now seems to say the following whatever package I use.
image

So it is now unusable - what's going on here?

@rdstern
Copy link
Collaborator

rdstern commented Sep 12, 2022

@N-thony I am not sure whether you could take this over, or re-allocate it.

@N-thony
Copy link
Collaborator

N-thony commented Oct 24, 2022

@rdstern I have tested this and it works for me. What you need before testing this is installing pingr package Ivan used here to satisfy the connectivity check to the internet.
This package should be added in the list of default packages of R-Instat.
image

@lloyddewit
Copy link
Contributor

What you need before testing this is installing pingr package Ivan used here to satisfy the connectivity check to the internet. This package should be added in the list of default packages of R-Instat.

@N-thony Please could you add the pingr package to R-Instat. An example of doing this is in PR #7557. If you add the coin package at the same time, then you can close PR #7719.
Thanks

@N-thony N-thony mentioned this pull request Oct 26, 2022
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed the pingr package, and it now works fine.

@lloyddewit lloyddewit changed the title Correct misleading message in Tools > Install R package dialogue Corrected misleading message in Tools > Install R package dialogue Nov 24, 2022
@lloyddewit lloyddewit added the bug label Nov 24, 2022
@lloyddewit lloyddewit merged commit 961339f into IDEMSInternational:master Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct misleading message in Tools > Install R package dialogue
4 participants