-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added extra features to Climatic > Model > Extremes dialog #7721
Added extra features to Climatic > Model > Extremes dialog #7721
Conversation
updating master
Updating master.
Improve extremes
Test extreme
Improve extremes
minor fix
@Tula1 Great to see you contributing to R-Instat. Welcome!
Done in PR #7724 |
@rdstern , Please have a look. |
@Tula1 that is a considerable improvement. It will be good for you to explain, ready for testers, what you have done to test the new dialogue, before expecting others to check. This to include which data you used, and what models you fitted. c) I tried the Bayesian fitting and it seems to work. I don't quite understand all the Bayesian options, so didn't change from the defaults that you supplied. Could you please give some descriptive details so I know what I can change. (I was fitting a gev.) I would like to alter aspects of the prior. d) I then added the year so I am fitting a non-stationary model. It didn't work. I then found that the original didn't work either, and that's because it doesn't like missing values that are different for the dependent and independent variables. (We do need to be able to filter out missing values in the data.) This was easy in this case, as it was just the last 2 years. So I deleted them. e) Then I tried again. I found the Bayesian doesn't work now. Possibly something needs to change in the priors. The ordinary MLE works fine. Please could you check this. |
Update Branch
@rdstern The issues raised above have now been sorted. Attached is a description of how the added parameters in the dialogs work. I have used the Dodoma Dataset to test the dialogs. Please have a look at it. |
great - thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lloyddewit and @N-thony I see I sort of "dropped the ball" on this one!). It is now a considerable improvement on the existing dialogue and it would be good to have it merged for the next release. I hope the code is ok or that either of you could make it ok, given @Tula1 has finished her internship.
I have copied the main points from here into an issue, so we can continue with the discussion by using the dialogue, once this is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@rdstern, @lloyddewit, @N-thony, @lilyclements This PR does not fix any issue but is part of my work.
I have been working with @Vitalis95 and @Ivanluv on improving the extremes dialog. These are the improvements:
i) Under the Bayesian fit method, prior parameters, Initial values and number of iterations was added to improve the model.
ii) We added the confidence intervals tab that outputs the parameter and return level, with corresponding return periods,
confidence intervals.
iii) We combined the fit method and display options sub dialogs into one sub dialog (Extremes Method) with separate tabs
ie fit method, Display Options and Confidence Interval to make it easier for the user.
@lloyddewit we have changed the
Fitting Options
tab in the main dialog toOptions
. Could you update this in the database to avoid merge conflicts when executed from my side.