-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a bug when reversing y-axis order in Density/Ridges plot in Histogram dialog #7763
Fixed a bug when reversing y-axis order in Density/Ridges plot in Histogram dialog #7763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lloyddewit, this the only change I made from my side (removing that line which is the one causing the bug). I never made any other change to this dialog. |
@Vitalis95 Thanks for the explanation. I'm not quite sure where the changes in the previous PR came from (parallel changes on the same file in master?). But these are reverted anyway so it's not important. I'm happy to approve. @rdstern over to you for testing ... |
updating branch
@rdstern the developer error is now sorted. The error "Discreet value supplied to continuous scale" is because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code is now better, so I am approving.
At a later stage we do need to be able to complete the discrete scales. However, I found the best way to reverse the months on the plot given in the issue is perhaps to reverse the levels in the factor first!
Fixes #6978
Replaces PR #7644
@rdstern @lloyddewit @N-thony ,this PR fixes the error when trying to reverse y-axis order in Density/Ridges plot