Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug when reversing y-axis order in Density/Ridges plot in Histogram dialog #7763

Merged
merged 3 commits into from Oct 10, 2022

Conversation

Vitalis95
Copy link
Contributor

Fixes #6978
Replaces PR #7644
@rdstern @lloyddewit @N-thony ,this PR fixes the error when trying to reverse y-axis order in Density/Ridges plot

Copy link
Contributor

@lloyddewit lloyddewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is much smaller than the changes in PR #7644 (which was merged and then reverted in PR #7739). What's the reason?

@Vitalis95
Copy link
Contributor Author

@lloyddewit, this the only change I made from my side (removing that line which is the one causing the bug). I never made any other change to this dialog.

@lloyddewit
Copy link
Contributor

@lloyddewit, this the only change I made from my side (removing that line which is the one causing the bug). I never made any other change to this dialog.

@Vitalis95 Thanks for the explanation. I'm not quite sure where the changes in the previous PR came from (parallel changes on the same file in master?). But these are reverted anyway so it's not important. I'm happy to approve.

@rdstern over to you for testing ...

lloyddewit
lloyddewit previously approved these changes Aug 12, 2022
N-thony
N-thony previously approved these changes Aug 28, 2022
@rdstern
Copy link
Collaborator

rdstern commented Sep 10, 2022

When I return to the dialogue I get (each time)
image

In addition, when I did reverse on the y-axis I got the following:
image

@Vitalis95 Vitalis95 dismissed stale reviews from N-thony and lloyddewit via fdf179c September 23, 2022 09:38
@Vitalis95
Copy link
Contributor Author

@rdstern the developer error is now sorted. The error "Discreet value supplied to continuous scale" is because month_abbr is factor

@N-thony
Copy link
Collaborator

N-thony commented Sep 27, 2022

@rdstern the developer error is now sorted. The error "Discreet value supplied to continuous scale" is because month_abbr is factor

@rdstern please have look

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the code is now better, so I am approving.
At a later stage we do need to be able to complete the discrete scales. However, I found the best way to reverse the months on the plot given in the issue is perhaps to reverse the levels in the factor first!

@lloyddewit lloyddewit added the bug label Oct 10, 2022
@lloyddewit lloyddewit merged commit e2b214b into IDEMSInternational:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error trying to reverse y-axis order
4 participants