-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved list names and default values in File > New Data Frame dialog #7788
Improved list names and default values in File > New Data Frame dialog #7788
Conversation
@rdstern, this is ready for review. Kindly have a look at it. |
The last commit includes changes that fixes #7799 as well. |
I updated the PR description so that when this PR is merged, it automatically closes the issue. |
@anastasia-mbithe in my comment above I realise that the 1,1000000 looks a bit odd for a beginner. So make it 1,1000 instead I think. Then it does not need changing for any data frame up to 1000. |
@N-thony could you examine the code for the defined variables? It should be easy to have the default of the first variable being numeric (with a variable from 1 upwards), while the default for any remaining variables remains as a character variable? |
@N-thony , kindly have a look at this. |
instat/dlgNewDataFrame.vb
Outdated
If iRow = 0 Then | ||
.Item(iRow).Cells(2).Value = "Numeric" | ||
.Item(iRow).Cells(3).Value = "1,1000" | ||
Else | ||
.Item(iRow).Cells(2).Value = "Character" | ||
.Item(iRow).Cells(3).Value = "NA" | ||
End If |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove this and keep it as it was.
instat/dlgNewDataFrame.vb
Outdated
.Item(iRow).Cells(2).Value = "Numeric" | ||
.Item(iRow).Cells(3).Value = "1,1000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.Item(iRow).Cells(2).Value = "Character"
.Item(iRow).Cells(3).Value = "NA"
it should remain character at this step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rdstern could you test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anastasia-mbithe and @N-thony I was poised to say we should give in on these changes. That's because they were taking too long, and were not so important. But to my great pleasure it all seems to work fine now. That's really great. Many thanks! @lloyddewit I hope the code is ok so this can be merged.
fixes #7771
fixes #7799
This is still in progress, am working to fix some emerging bugs.