Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved list names and default values in File > New Data Frame dialog #7788

Merged

Conversation

anastasia-mbithe
Copy link
Contributor

@anastasia-mbithe anastasia-mbithe commented Aug 18, 2022

fixes #7771
fixes #7799
This is still in progress, am working to fix some emerging bugs.

@anastasia-mbithe
Copy link
Contributor Author

anastasia-mbithe commented Aug 19, 2022

@rdstern, this is ready for review. Kindly have a look at it.
Though I couldn't get to use the last name, so I used the name from the second control that shows the lists per category.

instat/dlgNewDataFrame.vb Outdated Show resolved Hide resolved
instat/dlgNewDataFrame.vb Outdated Show resolved Hide resolved
instat/dlgNewDataFrame.vb Outdated Show resolved Hide resolved
instat/dlgNewDataFrame.vb Outdated Show resolved Hide resolved
instat/dlgNewDataFrame.vb Outdated Show resolved Hide resolved
instat/dlgNewDataFrame.vb Outdated Show resolved Hide resolved
@anastasia-mbithe
Copy link
Contributor Author

The last commit includes changes that fixes #7799 as well.

@lloyddewit
Copy link
Contributor

The last commit includes changes that fixes #7799 as well.

I updated the PR description so that when this PR is merged, it automatically closes the issue.

@rdstern
Copy link
Collaborator

rdstern commented Aug 23, 2022

On the File > New, I was ok with the row numbers being 10 and not I million.
Then when you press to see the names I am happy with the first variable x1, as you have it.
The second variable should be left as it was before, i.e. as a character variable filled with NA.
So:
image

@rdstern
Copy link
Collaborator

rdstern commented Aug 26, 2022

@anastasia-mbithe in my comment above I realise that the 1,1000000 looks a bit odd for a beginner. So make it 1,1000 instead I think. Then it does not need changing for any data frame up to 1000.

@anastasia-mbithe
Copy link
Contributor Author

@rdstern, I can't get a way of separating the change in the first row not to affect the second row, since the code fills the grid up to the nth row. It can however be done manually when one is using the dialog. @N-thony, you can check whether my view/ suggestion is correct.

@rdstern
Copy link
Collaborator

rdstern commented Sep 14, 2022

@N-thony could you examine the code for the defined variables? It should be easy to have the default of the first variable being numeric (with a variable from 1 upwards), while the default for any remaining variables remains as a character variable?

@anastasia-mbithe
Copy link
Contributor Author

@N-thony , kindly have a look at this.

Comment on lines 509 to 515
If iRow = 0 Then
.Item(iRow).Cells(2).Value = "Numeric"
.Item(iRow).Cells(3).Value = "1,1000"
Else
.Item(iRow).Cells(2).Value = "Character"
.Item(iRow).Cells(3).Value = "NA"
End If
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this and keep it as it was.

Comment on lines 507 to 508
.Item(iRow).Cells(2).Value = "Numeric"
.Item(iRow).Cells(3).Value = "1,1000"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.Item(iRow).Cells(2).Value = "Character"
.Item(iRow).Cells(3).Value = "NA"

it should remain character at this step

Copy link
Collaborator

@N-thony N-thony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdstern could you test?

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anastasia-mbithe and @N-thony I was poised to say we should give in on these changes. That's because they were taking too long, and were not so important. But to my great pleasure it all seems to work fine now. That's really great. Many thanks! @lloyddewit I hope the code is ok so this can be merged.

@lloyddewit lloyddewit changed the title Renaming Lists in the New DataFrame dialog Improved list names and default values in File > New Data Frame dialog Sep 29, 2022
@lloyddewit lloyddewit merged commit 9139bce into IDEMSInternational:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small improvement to the File > New Data Frame dialogue Make better names in File > New Data Frame > Lists?
4 participants