Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included list variables in the Prepare> Column: Text Options dialog #7790

Merged

Conversation

anastasia-mbithe
Copy link
Contributor

This fixes part c. of #7770

@rdstern, I have added lists as variables to be included in the Text: Transform dialog. However, I noticed that the other Text options as Split, Combine ...and the others included lists before because they are not restricted to either factor, character, or even list, so am wondering if we should restrict the variables (for the other options) to only list, factor, and character?

lloyddewit
lloyddewit previously approved these changes Aug 19, 2022
@rdstern
Copy link
Collaborator

rdstern commented Aug 21, 2022

@anastasia-mbithe good spot. I now have some numeric columns that I would like to trim the blanks. So let's allow them too. So really all types

@anastasia-mbithe anastasia-mbithe added this to In progress in Developers via automation Aug 22, 2022
Developers automation moved this from In progress to Review in progress Aug 22, 2022
@anastasia-mbithe
Copy link
Contributor Author

This is ready for review.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

Developers automation moved this from Review in progress to Reviewer approved Aug 27, 2022
@lloyddewit lloyddewit changed the title Including list variables in the Prepare> Column: Text Options Included list variables in the Prepare> Column: Text Options dialog Aug 27, 2022
@lloyddewit lloyddewit merged commit 4eadc22 into IDEMSInternational:master Aug 27, 2022
Developers automation moved this from Reviewer approved to Done Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants