-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended the PCA dialog #7869
Extended the PCA dialog #7869
Conversation
@Vitalis95 is this the new PCA dialogue? It looks like the old one (so just a single receiver) and gave a problem with a simple example as well. |
@rdstern are you sure you synced your branch? I can see the changes on my version @Vitalis95 I get the following bug if I fill the boxes in and press OK |
@Vitalis95 @lilyclements was correct I wasn't using the right branch. Then I tried the other plot options and only the scree plot seems to work. The others all failed. From the presentation with this package there seemed to be many plotting options. Are these updated yet to permit all that is possible from the new system, particularly those with the added variables. With the new output window perhaps @Patowhiz can also advise. We are currently limited to a single graph at a time. Will that limit still be there, or could we get multiple graphs now? |
I still need to design for multiple outputs. Essentially, we need to detect when an R object has multiple outputs when printed. Once that's possible we can trivially have the output window display them. We can do that once we are done with the new way of processing R objects. |
@rdstern, to avoid the bug, I have excluded the variables from the selector once added to Explanatory Variable receiver to avoid using them also in Suppl.Numeric Receiver . I did wrote an email to Francois Husson the author of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! @rdstern this is ready for you review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vitalis95 this is looking really good now and I am approving.
Later we could revisit, or you could explain - as we write the help. I am still not sure how we plot the options with the extra variables and factors. That can be come later though!
Fixes #7318
Fixes #6686
Replaces PR #7654 due to conflicts
@rdstern @lloyddewit @lilyclements , have a look at it