Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended the PCA dialog #7869

Merged
merged 7 commits into from Oct 4, 2022
Merged

Conversation

Vitalis95
Copy link
Contributor

Fixes #7318
Fixes #6686
Replaces PR #7654 due to conflicts
@rdstern @lloyddewit @lilyclements , have a look at it

@rdstern
Copy link
Collaborator

rdstern commented Sep 10, 2022

@Vitalis95 is this the new PCA dialogue? It looks like the old one (so just a single receiver) and gave a problem with a simple example as well.

@lilyclements
Copy link
Contributor

@rdstern are you sure you synced your branch? I can see the changes on my version

@Vitalis95 I get the following bug if I fill the boxes in and press OK

image

@rdstern
Copy link
Collaborator

rdstern commented Sep 10, 2022

@Vitalis95 @lilyclements was correct I wasn't using the right branch.
I got the same error as above.
I also tried with the diamonds data and there was too much printout. So I chose not to get the eigenvectors and that was much better. I suggest not having the eigenvectors could be the default.

Then I tried the other plot options and only the scree plot seems to work. The others all failed.

From the presentation with this package there seemed to be many plotting options. Are these updated yet to permit all that is possible from the new system, particularly those with the added variables.

With the new output window perhaps @Patowhiz can also advise. We are currently limited to a single graph at a time. Will that limit still be there, or could we get multiple graphs now?

@Patowhiz
Copy link
Contributor

I still need to design for multiple outputs. Essentially, we need to detect when an R object has multiple outputs when printed. Once that's possible we can trivially have the output window display them.

We can do that once we are done with the new way of processing R objects.

@Vitalis95
Copy link
Contributor Author

@rdstern, to avoid the bug, I have excluded the variables from the selector once added to Explanatory Variable receiver to avoid using them also in Suppl.Numeric Receiver . I did wrote an email to Francois Husson the author of FactoMineR package to inquire if it is possible to use the same variable(s) in active variables as well as in quantitative supplementary variables, he responded that he doesn't have any example where a variable already used as active could be also used as illustrative (quantitative supplementary variables).
From the documentation it says these supplementary variables have no influence on the principal components of the analysis but they help to interpret the dimensions of variability-they are not taken into account in the PCA computations.

Copy link
Contributor

@lilyclements lilyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! @rdstern this is ready for you review

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vitalis95 this is looking really good now and I am approving.
Later we could revisit, or you could explain - as we write the help. I am still not sure how we plot the options with the extra variables and factors. That can be come later though!

@lloyddewit lloyddewit changed the title Improving PCA dialog Extended the PCA dialog Oct 4, 2022
@lloyddewit lloyddewit merged commit 3f8c2bb into IDEMSInternational:master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend the PCA dialogue PCA Options subdialog, Save Tab Empty
5 participants