Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured that the 'Try' message in the Calculator, and some other diogs, is correctly translated (e.g. to/from French) #7883

Merged
merged 1 commit into from Oct 11, 2022

Conversation

lloyddewit
Copy link
Contributor

@lloyddewit lloyddewit commented Sep 15, 2022

Fixes #7774.
Specifically, this fixes the part 'e' of issue #7774 (see screenshot below). The rest of this issue is covered by issue #3721, therefore it's OK for this PR to auttomatically close #7774 when this PR is merged.
This PR should also fix this issue for all other dialogs that use the ucrTry control.

@N-thony Please could you peer review? The database changes are shown below.
@rdstern Please could you test?

Thanks!

image

image

…ogs, is correctly translated (e.g. to/from French)
@lloyddewit lloyddewit added the bug label Sep 15, 2022
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine
I did notice that the French is a bit verbose for the control, but that's a different problem.

@lloyddewit
Copy link
Contributor Author

@N-thony If you can review/approve, then we can merge, thanks

@N-thony
Copy link
Collaborator

N-thony commented Oct 11, 2022

@lloyddewit over to you.

@lloyddewit lloyddewit merged commit 40a13a8 into IDEMSInternational:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate popup menus in R-Instat
3 participants