-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Hide/Unhide Dataframe(s) dialog #7905
Improved Hide/Unhide Dataframe(s) dialog #7905
Conversation
updating master
updating master
updating master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vitalis95 I am not sure how this is supposed to work?
I had a number of data frames and hid some using the bottom right-click. (They just hid without showing the dialogue.) Then I pressed Unhide and it gave me your new dialogue. I then tried to unhide those that were hidden, though it listed all of them. And I couldn't use Add or double-click to put them into the receiver in unhide. They did go into the receiver with Hide. (But they were already hidden!
@rdstern , have a look at it. |
@derekagorhom can you peer review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just some small comments
@Vitalis95 is this ready for re-review? |
@N-thony , yes. Could you test it? |
@N-thony , the reset issue is now ok. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lloyddewit over to you
@Vitalis95 this is looking pretty good now. |
@rdstern , have a look at it for part c). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vitalis95 looks fine now. Thanks.
Once @lloyddewit approves it will be good to merge.
Fixes #7533
@rdstern @N-thony @lloyddewit , I have added 2 radio buttons(Hide &Unhide), this improvements simplify the dialog for the user