Ensured correct result from 3-way frequencies dialog #7916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derekagorhom can you peer review this? |
derekagorhom
approved these changes
Oct 24, 2022
lloyddewit
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
@N-thony Thank you for the changes, looks good to me.
@derekagorhom Thank you for the peer review.
|
@rdstern if you can test, then we can merge, thanks |
lloyddewit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7741
@rdstern please check if the result is now correct? Thanks
Probably you could play around with the dialogue and see if everything expected is correct?