Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Scale/Distance & Random Split dialogs to the database #7926

Merged
merged 7 commits into from Oct 28, 2022

Conversation

Vitalis95
Copy link
Contributor

Fixes Partly #7749
@lloyddewit , @N-thony , this PR adds Scale/Distance dialog and Random split dialog to the database

@Vitalis95
Copy link
Contributor Author

Here are the screenshots of the changes.

image

image

image

image

image

@Vitalis95
Copy link
Contributor Author

@MeSophie , I have changed the label in the database to Save As: to be consistent with the label in the designer

image

N-thony
N-thony previously approved these changes Oct 24, 2022
Copy link
Collaborator

@N-thony N-thony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lloyddewit over to you

@lloyddewit
Copy link
Contributor

@Vitalis95 Thank you for the updates.
Please see my comment in issue #7749. I think all of these should be resolved when PR #7908 and PR #7927 are merged, apart from:

  • Number of Preview Rows:
  • Scale/Distance
  • Selected Variables
  • New Data Frame Name:

Please could you investigate whether these strings also need to be added to the database?
If you need any help, then please let me know.
Thanks

@N-thony
Copy link
Collaborator

N-thony commented Oct 27, 2022

@Vitalis95 Thank you for the updates. Please see my comment in issue #7749. I think all of these should be resolved when PR #7908 and PR #7927 are merged, apart from:

  • Number of Preview Rows:
  • Scale/Distance
  • Selected Variables
  • New Data Frame Name:

Please could you investigate whether these strings also need to be added to the database? If you need any help, then please let me know. Thanks

@Vitalis95 this PR contains database changes, it will be good to make the changes requested if possible quickly to avoid conflicts which will lead you to create another PR.

@Vitalis95
Copy link
Contributor Author

@lloyddewit , the other strings are already in the database. The designer change is because the label and the control were overlapping when in French language

image

@lloyddewit
Copy link
Contributor

@Vitalis95 Thank you all the well-documented changes. I'm happy to merge.
When PR #7908 is also merged, then we can retest issue #7749 and identify any remaining missing translations.

@lloyddewit lloyddewit merged commit a960e19 into IDEMSInternational:master Oct 28, 2022
@lloyddewit lloyddewit added the skip-releasenotes PRs that don't affect functionality and should not be included in the release notes label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-releasenotes PRs that don't affect functionality and should not be included in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants