Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made small aesthetic fixes to Line Plot dialog #7951

Merged
merged 3 commits into from
Dec 29, 2022

Conversation

MeSophie
Copy link
Contributor

@MeSophie MeSophie commented Nov 3, 2022

I make some modifications according to @rdstern last comment in PR#7762.
@N-thony please have a look.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeSophie thanks for this. I can't tell really until it is merged.
I just take the opportunity to ask another question and at the same time suggest a very minor change that has been annoying me for a long time - but it has been too small to make a special issue.

So under the fitted line there is the option to "Add peaks and Valleys" In French peaks is translated as pics. I assume that is ok as the translation?
Now the very small change - the checkbox for valleys is too high! Could you move it down so it is exactly lined up with the checkbox for the peaks (pics!).
Thanks

@N-thony
Copy link
Collaborator

N-thony commented Dec 14, 2022

@MeSophie thanks for this. I can't tell really until it is merged. I just take the opportunity to ask another question and at the same time suggest a very minor change that has been annoying me for a long time - but it has been too small to make a special issue.

So under the fitted line there is the option to "Add peaks and Valleys" In French peaks is translated as pics. I assume that is ok as the translation? Now the very small change - the checkbox for valleys is too high! Could you move it down so it is exactly lined up with the checkbox for the peaks (pics!). Thanks

@MeSophie can you make the changes and solve the conflicts?

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lloyddewit these are small changes and I am approving.
I note that Derek is also working on the same dialogue. Let's merge this quickly, so he can proceed with more major edits in #8017 .

@lloyddewit lloyddewit changed the title Minor Modifications on LinePlot Dialog Made small aesthetic improvements to LinePlot dialog Dec 29, 2022
@lloyddewit lloyddewit changed the title Made small aesthetic improvements to LinePlot dialog Made small aesthetic fixes to LinePlot dialog Dec 29, 2022
@lloyddewit lloyddewit changed the title Made small aesthetic fixes to LinePlot dialog Made small aesthetic fixes to Line Plot dialog Dec 29, 2022
@lloyddewit lloyddewit merged commit 4e7a045 into IDEMSInternational:master Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants