Enhanced New Dataframe dialog #7964
Conversation
There was a problem hiding this comment.
@N-thony I am approving, because it does solve the problem that we found. So it could be merged.
But there are also problems with the defaults of letters(1,10) and LETTERS(1,10) that you may want to resolve at the same time.
There are 2 problems with those options:
a) when they are used they currently only work if the length of the data frame is a multiple of 10. It usually will be, but if you put the usual rep round it, then it would always work.
b) They won't work, when the variable is numeric or integer. So check if they are set. I suggest if they are set and the type is numeric or integer, you make that variable into character instead.
c) Also they won't work if the type is set to be a factor and you have set the levels. So, again, check that and make it a character variable instead.
instat/dlgNewDataFrame.vb
Outdated
| Dim iColDefaultIndex As Integer = dataTypeGridView.CurrentRow.Cells("colDefault").ColumnIndex | ||
| Dim iRowDefaultIndex As Integer = dataTypeGridView.CurrentRow.Cells("colDefault").RowIndex |
There was a problem hiding this comment.
these are only used on line 608.
Move these lines into the line 606 If block.
@lloyddewit I will make them later. |
lloyddewit
changed the title
Fixes #7957
@berylwaswa can you test this? Thanks.