Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the new variable name in Prepare> Column:Text> Split dialog #8097

Merged

Conversation

anastasia-mbithe
Copy link
Contributor

This fixes #8085

@rdstern and @N-thony, this is ready for testing.

@berylwaswa
Copy link

I have tested the split dialog with the data provided by Roger and it works fine now.

Here is the data set:

PGStation.zip

I split the same variable thrice.
a) I first split on a space - and made the prefix into morning, and this worked fine.
b) Then I split again on the morning variable using the colon for the split. I called it hour, and it was split into hour and hour1.
c) Then I split again the morning variable using semi-colon for the split. I called it min, and it was split into min and min1.

It now changes the name from morning to the given prefixes.

instat/dlgSplitText.vb Outdated Show resolved Hide resolved
R-Instat February Mini Sprint automation moved this from To do to Review in progress Feb 6, 2023
@lloyddewit
Copy link
Contributor

@anastasia-mbithe Thank you, this looks good to me.

@N-thony @berylwaswa May I merge this? Or do you prefer to wait and see if @rdstern has time to test/approve?

@rdstern we (@N-thony @berylwaswa and I) discussed the testing approach this morning. We agreed that, during the sprint, for lower risk PRs, that we may go ahead and merge without your test/approval. You would have the option to test later, and we could raise issues for any problems found (and fix these before the Feb build). I hope that's OK. If you prefer a different approach, then please let us know.

Thanks

@rdstern
Copy link
Collaborator

rdstern commented Feb 6, 2023

Perfect on the merging this week.

@lloyddewit lloyddewit changed the title Fixing the new variable name in Prepare> Column:Text> Split dialog Fixed the new variable name in Prepare> Column:Text> Split dialog Feb 7, 2023
@lloyddewit lloyddewit added the bug label Feb 7, 2023
@lloyddewit lloyddewit merged commit 613aa5e into IDEMSInternational:master Feb 7, 2023
R-Instat February Mini Sprint automation moved this from Review in progress to Completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Correct the new variable name in the Prepare > Column: Text > Split dialogue
4 participants