Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured output from Describe >One variable >Frequencies dialog is correct #8111

Merged

Conversation

anastasia-mbithe
Copy link
Contributor

Fixes partially #8104

@rdstern, @Patowhiz and @lloyddewit
I have implemented the new output system in this dialog.

  1. I have disabled the Both option since the new output system does not support producing two objects simultaneously. From the discussion with @Patowhiz, it's so easy for a user to go back and produce the other object when needed.
  2. The dialog uses only one save control now.
  3. The panel that initially controlled save as text(viewer) or HTML (browser) now controls save as a table and save as a data frame, for the Table option.

@lloyddewit
Copy link
Contributor

@berylwaswa please could you test? thanks

@berylwaswa
Copy link

@lloyddewit @anastasia-mbithe this looks good.
The Both option has been disabled and it's easy to go back and produce the other object.
The dialog uses only one save control.

@lloyddewit lloyddewit changed the title Implementing new output system on Describe >One variable >Frequencies dialog Implemented new output system in Describe >One variable >Frequencies dialog Feb 9, 2023
@lloyddewit lloyddewit merged commit 9d24090 into IDEMSInternational:master Feb 9, 2023
@lloyddewit lloyddewit changed the title Implemented new output system in Describe >One variable >Frequencies dialog Implemented output from Describe >One variable >Frequencies dialog is correct Feb 9, 2023
@lloyddewit lloyddewit added bug and removed feature labels Feb 9, 2023
@lloyddewit lloyddewit changed the title Implemented output from Describe >One variable >Frequencies dialog is correct Ensured output from Describe >One variable >Frequencies dialog is correct Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants