-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset the Scrollbar position on the DataView Grid at the top when Filter is applied #8121
Reset the Scrollbar position on the DataView Grid at the top when Filter is applied #8121
Conversation
Updating master br
Upating local master
Merge master local
@berylwaswa if you can test, then we can merge, thanks |
@N-thony while you are here could you check the same thing "sideways". I had 34 columns and only saw 30. When I was at Variable 30 I went to the second page it was blank. I think it is ok if I am at variable 1. I have just confirmed with a blank data frame of 35 variables (if the limit is 30). If I am on Variable x1 and the move to the next page, all is fine. But if I am on x30, then the next page appears blank. It is ok once I press in the blank data frame. But again it would be good to set back to the first variable visible, before changing the page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@N-thony I confirm that the scrolling vertically seems fixed. I then looked at scrolling horizontally with a new data frame of width 54 (my number of variables is set to 50) and hope the same can be done for this?
If you prefer it to be another pull request, then I'll approve this one.
The solution here fixes the issue but it doesn't solve the problem in the Grid in general because the same problem found with the columns is also with the rows. I will try to fix it more general with the Grid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving, because the sideways problem can be in a separate pull request. And it would be good to have this feature fixed in time for the March workshops
Fixes #8116
@rdstern @lloyddewit I made the change so that the scrollbar will always go at the top when the filter is applied. Have a look.