-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed grid to only update one cell if replace value is done #8166
Changed grid to only update one cell if replace value is done #8166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisMarsh82 I tried on a large dataset, where I had noticed the problem before. It had 875,000 rows.
I needed to change temperaures measured such as 305 degrees to 30.5. There were about 11 rows like this. I first tried with a filter, so just the 11 rows were visible. A cell change took about 4 seconds. I bit long, but not impossible.
When I noted the row number and tried on the unfiltered data it took only 2 seconds.
I tried with your stated change and also (for comparison) with the released version. There seemed no change in those times, between the 2 versions.
I had no problem with your new version, so am approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisMarsh82 Thank you for the changes, just some small comments.
Also, I understand that the purpose of this PR is to increase performance. During his testing, @rdstern found the speed similar to the previous version. Before we increase the code complexity, I think we should demonstrate a speed improvement. Do you have a test case that could show this?
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
renamed boolean to have b prefix changed methods to private
@rdstern @lloyddewit The changes I have made only stop the grid being fully loaded from the dataframe. The dataframe is fully refreshed so in some cases it won't appear any quicker. Where the benefit will come in if you have a large dataset with a lot of rows and where those rows contain lists with lots of values. |
Updated ReplaceValueInCell to only update the changed cell.
At the moment we still bring back the entire dataframe from R so there is still a delay. This would be a much bigger change and could run into errors. This change should at least half the time taken to refresh