Fixed bugs on the New Data Frame dialog #8169
Conversation
There was a problem hiding this comment.
@derekagorhom that's a releif that I think the main bug is fixed. I couldn't get an error. But there are still some more bits to correct.
a) As mentioned previously, when I untick the Variable Name checkbox it also works. But when I return to the dialogue the Variable Name is ticked for me again. The rule, in R-Instat is that the controls "remember" how they were left. So please keep that control unticked if that was done the last time Ok was pressed.
b) I am also happy that changing a name in the variables now seems ok. But changing the type to numeric, or factor doesn't work yet. Please can those be fixed too.
|
@derekagorhom I hope this is still work in progress - but you need to comment more when you make changes, so I know when I should look again. I am very keen that this is fixed in time for the February release this weekend. And the other problems - only character variables despite what I change - still remain. Please also discuss with @N-thony because he did the original code and it worked fine then. |
|
@rdstern i fixed the issue with the variable type and also made code changes to check variable name so that it is default and it can be ticked and unticked with no issues. |
There was a problem hiding this comment.
@derekagorhom, well done it all seems to work fine now.
@lloyddewit it would be good to merge this, once you are happy with the code. @ChrisMarsh82 found serious problems with the Version 0.7.8 version.
lloyddewit
changed the title
rdstern
changed the title
Fixes #8167
This fixes the recent bug found when the dialogue fails to create a dataframe with less than 3 columns.
@ChrisMarsh82 , @rdstern, this PR is ready for review.