Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Rhelp for Model Menu Dialogs #8181

Merged

Conversation

derekagorhom
Copy link
Contributor

fixes #8160
replaces #8165

I have updated this branch with the changes done on PR #8159 added the Rhelp dropdown to the Use Model keyboard, Hypothesis Tests, Fit Model and Prepare > Column: Numeric > Enter dialogue.

@N-thony , @rdstern this PR is ready for review.

@derekagorhom derekagorhom changed the title Rhelp for Model Menus Rhelp for Model Menu Dialogues Mar 1, 2023
rdstern
rdstern previously approved these changes Mar 1, 2023
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekagorhom well done. This works really nicely now.
@lloyddewit I hope the code is ok, and if so it could be merged soon?
@ChrisMarsh82 if it is merged, and you are doing another build, then it would be good to include this. It fixes a couple of small errors in the Model Keyboard dialogue. But it isn't worth making a special effort for this. I'd be delighted if anyone used this dialogue sufficiently to find these problems. Maybe worth a small prize. So no harm if it waits for the March release.

Copy link
Contributor

@lloyddewit lloyddewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekagorhom Thanks for the PR, looks good, just a few comments

instat/dlgEnter.vb Outdated Show resolved Hide resolved
instat/dlgEnter.vb Outdated Show resolved Hide resolved
instat/dlgHypothesisTestsCalculator.vb Outdated Show resolved Hide resolved
instat/dlgUseModel.vb Outdated Show resolved Hide resolved
instat/dlgUseModel.vb Outdated Show resolved Hide resolved
instat/dlgUseModel.vb Outdated Show resolved Hide resolved
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
derekagorhom and others added 2 commits March 3, 2023 10:22
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
@derekagorhom
Copy link
Contributor Author

derekagorhom commented Mar 3, 2023

@lloyddewit i have made all the changes except the one related the clsHelp function on dlgEnter.
can you have a look.
Thanks

@lloyddewit
Copy link
Contributor

@lloyddewit i have made all the changes except the one related the clsHelp function on dlgEnter. can you have a look. Thanks

@derekagorhom thanks, just open comment above.

@lloyddewit
Copy link
Contributor

@derekagorhom thank you, looks good, happy to approve.

@rdstern there are some small changes since your last approval. If you can test/approve, then we can merge, thanks

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@lloyddewit lloyddewit changed the title Rhelp for Model Menu Dialogues Improved Rhelp for Model Menu Dialogs Mar 27, 2023
@lloyddewit lloyddewit merged commit 3f05365 into IDEMSInternational:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the calls to R help
3 participants