Fixed a bug in Tidy Climatic Data dialog #8204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating master
updating master
updating master
N-thony
approved these changes
Mar 8, 2023
rdstern
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
@Vitalis95 This was a serious bug-find. Many thanks. It now works fine on the data we had for this workshop.
@lloyddewit I hope this can be merged, and perhaps even an update released if it isn't too much work for Chris?
It would also help on next week's workshop.
lloyddewit
approved these changes
Mar 9, 2023
lloyddewit
changed the title
|
@ChrisMarsh82 Please could you coordinate with @rdstern to see if it's worth creating a release for this bug fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8201
@rdstern @lloyddewit , the bug is as result of missing default value of
element_name. It was removed from the function and added as parameter, I have restored it. Have a look it now.